Skip to content

Conversation

@holmeso
Copy link
Contributor

@holmeso holmeso commented Feb 11, 2025

Description

MIN is applied if 2 reads support the alt in the normal. MIUN is applied if 2 reads that failed the filter support the alt in the normal, but nothing was being applied if 1 passed filter read and 1 failed filter read supported the normal . This has now been addressed

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Additional unit tests have been added, and existing ones modified to accomodate this change.

Are WDL Updates Required?

no

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

MIN is applied if 2 reads support the alt in the normal. MIUN is applied if 2 reads that failed the
filter support the alt in the normal, but nothing was being applied if 1 passed filter read and 1
failed filter read supported the normal . This has now been addressed
Copy link
Contributor

@newellf newellf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@holmeso holmeso merged commit b2e9e71 into master Feb 11, 2025
1 check passed
@holmeso holmeso deleted the qanno_miun_fix branch February 11, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants